Difference between revisions of "User talk:Trang Oul"

From Basin Wiki
Jump to navigation Jump to search
 
(15 intermediate revisions by 2 users not shown)
Line 29: Line 29:
 
:I'll leave it to you how we/you record the patch number. As you said, it's purely historical anyway. :)
 
:I'll leave it to you how we/you record the patch number. As you said, it's purely historical anyway. :)
 
:Cheers, [[User:Naturelover|Naturelover]] ([[User talk:Naturelover|talk]]) 18:16, 25 June 2024 (EDT)
 
:Cheers, [[User:Naturelover|Naturelover]] ([[User talk:Naturelover|talk]]) 18:16, 25 June 2024 (EDT)
 +
:PS: What's the difference between <br> and <br/> ?
 +
 +
:Fortunately there are few pages with patch numbers, so it's not a big deal.
 +
: Speaking of ''br'' tags, it's a [https://stackoverflow.com/questions/1946426 long story], but I prefer to close the tags (i.e. ''<nowiki><br/></nowiki>'') instead of leaving them open. After all, [https://peps.python.org/pep-0020/ explicit is better than implicit]. [[User:Trang Oul|Trang Oul]] ([[User talk:Trang Oul|talk]]) 05:50, 26 June 2024 (EDT)
 +
 +
== Item Type page ==
 +
 +
Hello TO,
 +
 +
just to let you know that the png at the beginning of the page doesn't display for me. I'm using Firefox on a Win 11 Pro system, all patched.
 +
 +
:Image: same here. If you open the image page (https://www.theamazonbasin.com/wiki/index.php/File:Item_Types_weap_armo.png), you'll see it broken. The same if you open one of the thumbnails, say, https://www.theamazonbasin.com/wiki/thumb.php?f=Item_Types_weap_armo.png&width=1024 . It seems the thumbnail generating script is broken (as everything here...). But you can open the "Original file": https://www.theamazonbasin.com/wiki/images/a/a1/Item_Types_weap_armo.png [[User:Trang Oul|Trang Oul]] ([[User talk:Trang Oul|talk]]) 04:54, 1 July 2024 (EDT)
 +
 +
Second thing: You have created a group of Spears and Polearms?! What is that grouping based on? The game clearly differentiates between those two (barb has a mastery for each one, amazons can rock spears and javs, but not polearms) - so why group them together? Based on what? ANd why D2R only? [[User:Naturelover|Naturelover]] ([[User talk:Naturelover|talk]]) 04:31, 1 July 2024 (EDT)
 +
 +
:[[Spears and Polearms]]: D2R data files, namely itemtypes.txt (definition) and monstats.txt (usage; new columns with hirelings equipment, moved from hireling.txt). This is a grouping item type, with no items directly using this type, like [[Swords and Knives]]. And D2R only simply because it didn't exist in LoD. [[User:Trang Oul|Trang Oul]] ([[User talk:Trang Oul|talk]]) 04:54, 1 July 2024 (EDT)
 +
::Thanks. And a comment: On the small/large/grand charm pages you wrote "Called Charm xxx in the game data files in LoD" - do you really mean LoD or maybe d2r? [[User:Naturelover|Naturelover]] ([[User talk:Naturelover|talk]]) 04:57, 1 July 2024 (EDT)
 +
::: LoD. In D2R in misc.txt they are called "xxx Charm", as seen in the game. It seems in LoD files those names were "beta"/"dev", and in D2R "production". Example: "viper amulet" in LoD vs. "Amulet of the Viper" in D2R, "Skeleton Key"/"Key" (the key to open chests, not keys for Ubers), "Sa'''ph'''ire"/"Sa'''pph'''ire" and so on. [[User:Trang Oul|Trang Oul]] ([[User talk:Trang Oul|talk]]) 05:08, 1 July 2024 (EDT)
 +
 +
:After further investigation, I found a possible reason to create <code>sppl</code> item type. In LoD hireling gear was defined in <code>hireling.txt</code> in columns <code>WType1</code> and <code>WType2</code> - '''two''' columns. These columns are absent in D2R. Instead, in <code>monstats.txt</code> new columns were introduced (in [https://news.blizzard.com/en-us/diablo2/23788293/diablo-ii-resurrected-patch-2-4-ladder-now-live#mod 2.4]): <code>rightArmItemType</code> and <code>leftArmItemType</code> - '''one''' column per slot (and also <code>canNotUseTwoHandedItems</code> to handle dual/2h barb mercs). So, it seems that to allow desert mercs to use both polearms and spears, a new item type had to be created as a container for both of them. Again, it's only my guess, but seems plausible. [[User:Trang Oul|Trang Oul]] ([[User talk:Trang Oul|talk]]) 05:04, 1 July 2024 (EDT)
 +
:One more discovery: D2R also introduced <code>none</code> item type, which is used to indicate that some hirelings cannot equip a second weapon (<code>monstats.txt</code>, col <code>leftArmItemType</code>). Maybe after D2R changes this column cannot be just left empty? Anyway, I haven't decided to create the page for that item type (yet), as it seems to be ''too'' technical. [[User:Trang Oul|Trang Oul]] ([[User talk:Trang Oul|talk]]) 07:35, 1 July 2024 (EDT)
 +
::Nice findings - didn't know you were sniffing out the code. :D [[User:Naturelover|Naturelover]] ([[User talk:Naturelover|talk]]) 18:40, 1 July 2024 (EDT)

Latest revision as of 18:40, 1 July 2024

Suggestion

Hey Trang Oul,

May I suggest that before you add a D2R RW to a new attribute page that you change existing "yes" for "Ladder" to "yes (LoD only)" until we have found a better solution if it hasn't been done yet? Otherwise we'll have both "yes (D2R only" and plain "yes" on a page which is even more confusing, as can be seen on the "cannot be frozen" page before I changed it. Thanks! Best, Naturelover (talk) 17:03, 15 June 2024 (EDT)

Sure. I'm thinking about using a template (multiple or, better, one parametrized) for all those "Yes (LoD only)" and so on ladder/availability descriptions. Then we'll be able to change all pages at once, if we decide to change those labels. Trang Oul (talk) 09:08, 20 June 2024 (EDT)

individual rune pages

Hi again!

I won't be using the individual rune pages (like Eld Rune or Ko Rune at all, so don'T care about the format. So would you prefer seperate columns for LoD and D2R patches / ladder or integrated into one column for patch / ladder? Just let me know that we don'T do any work twice, thanks. Naturelover (talk) 09:03, 20 June 2024 (EDT)

I'd go for atomic (separate) data. Sortable and more readable. Trang Oul (talk) 10:26, 20 June 2024 (EDT)

Patches

Hello again,

me once more. I just noticed that Blizzard use a 2.x.y format for their patches for d2r (current is 2.7.3 e.g.) and not 1.ab like they used to with d2 and lod. So all my 2.00 2.40 and 2.60 edits were wrong and should've been 2.6 or 2.6.0 instead. I don't think I'm going to change it. But just wanted to let you know that I screwed up in this regard. :( Cheers, Naturelover (talk) 07:28, 22 June 2024 (EDT)

Hi Naturelover,

In my edits I've used x.y format (i.e. only major and minor, without patch (as defined here)). This is the format used in news (examples: 2.4, [1]), and also used by the community, since only the "big" patches introduced new features. But maybe we should be more detailed here? On the other hand, unlike LoD, I don't think it is even possible to install older D2R patches, so that information is purely historical.
PS. Shall I answer you here or on your page? :) Trang Oul (talk) 02:00, 25 June 2024 (EDT)

Hello TO,
answering here is fine.
I'll leave it to you how we/you record the patch number. As you said, it's purely historical anyway. :)
Cheers, Naturelover (talk) 18:16, 25 June 2024 (EDT)
PS: What's the difference between
and
 ?
Fortunately there are few pages with patch numbers, so it's not a big deal.
Speaking of br tags, it's a long story, but I prefer to close the tags (i.e. <br/>) instead of leaving them open. After all, explicit is better than implicit. Trang Oul (talk) 05:50, 26 June 2024 (EDT)

Item Type page

Hello TO,

just to let you know that the png at the beginning of the page doesn't display for me. I'm using Firefox on a Win 11 Pro system, all patched.

Image: same here. If you open the image page (https://www.theamazonbasin.com/wiki/index.php/File:Item_Types_weap_armo.png), you'll see it broken. The same if you open one of the thumbnails, say, https://www.theamazonbasin.com/wiki/thumb.php?f=Item_Types_weap_armo.png&width=1024 . It seems the thumbnail generating script is broken (as everything here...). But you can open the "Original file": https://www.theamazonbasin.com/wiki/images/a/a1/Item_Types_weap_armo.png Trang Oul (talk) 04:54, 1 July 2024 (EDT)

Second thing: You have created a group of Spears and Polearms?! What is that grouping based on? The game clearly differentiates between those two (barb has a mastery for each one, amazons can rock spears and javs, but not polearms) - so why group them together? Based on what? ANd why D2R only? Naturelover (talk) 04:31, 1 July 2024 (EDT)

Spears and Polearms: D2R data files, namely itemtypes.txt (definition) and monstats.txt (usage; new columns with hirelings equipment, moved from hireling.txt). This is a grouping item type, with no items directly using this type, like Swords and Knives. And D2R only simply because it didn't exist in LoD. Trang Oul (talk) 04:54, 1 July 2024 (EDT)
Thanks. And a comment: On the small/large/grand charm pages you wrote "Called Charm xxx in the game data files in LoD" - do you really mean LoD or maybe d2r? Naturelover (talk) 04:57, 1 July 2024 (EDT)
LoD. In D2R in misc.txt they are called "xxx Charm", as seen in the game. It seems in LoD files those names were "beta"/"dev", and in D2R "production". Example: "viper amulet" in LoD vs. "Amulet of the Viper" in D2R, "Skeleton Key"/"Key" (the key to open chests, not keys for Ubers), "Saphire"/"Sapphire" and so on. Trang Oul (talk) 05:08, 1 July 2024 (EDT)
After further investigation, I found a possible reason to create sppl item type. In LoD hireling gear was defined in hireling.txt in columns WType1 and WType2 - two columns. These columns are absent in D2R. Instead, in monstats.txt new columns were introduced (in 2.4): rightArmItemType and leftArmItemType - one column per slot (and also canNotUseTwoHandedItems to handle dual/2h barb mercs). So, it seems that to allow desert mercs to use both polearms and spears, a new item type had to be created as a container for both of them. Again, it's only my guess, but seems plausible. Trang Oul (talk) 05:04, 1 July 2024 (EDT)
One more discovery: D2R also introduced none item type, which is used to indicate that some hirelings cannot equip a second weapon (monstats.txt, col leftArmItemType). Maybe after D2R changes this column cannot be just left empty? Anyway, I haven't decided to create the page for that item type (yet), as it seems to be too technical. Trang Oul (talk) 07:35, 1 July 2024 (EDT)
Nice findings - didn't know you were sniffing out the code. :D Naturelover (talk) 18:40, 1 July 2024 (EDT)